ci: Enable floating tags - #1627
Merged
Merged
Conversation
This... is... very cumbersome. Thanks GitHub.
This reverts commit d503797.
Techassi
marked this pull request as ready for review
September 2, 2026 14:06
Techassi
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
dervoeti
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
dervoeti
self-requested a review
September 3, 2026 07:56
dervoeti
reviewed
Sep 3, 2026
dervoeti
left a comment
dervoeti
left a comment
Member
There was a problem hiding this comment.
Regarding the defaults job, would something like this work maybe?
with:
product-name: krb5
sdp-version: ${{ case(github.ref_type == 'tag', github.ref_name, '0.0.0-dev') }}
registry-namespace: sdp
# Keep these defaults in sync with the workflow_dispatch input defaults above.
publish: ${{ github.event_name != 'workflow_dispatch' || inputs.publish }}
floating-tag: ${{ github.event_name == 'workflow_dispatch' && inputs.floating-tag }}
Would shorten the whole code quite a bit.
dervoeti
approved these changes
Sep 3, 2026
dervoeti
left a comment
dervoeti
left a comment
Member
There was a problem hiding this comment.
LGTM, just one optional suggestion to make the code more compact.
Member
Author
I honestly don't know, because empty values behave very weirdly in GHA. They only sometimes become a faulty value. This definitely would need a round of testing. I'm happy to explore this option, but would prefer to do so in a separate PR. |
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/stackabletech/internal-issues/issues/169.
Note
These changes were tested as best as they could here:
It should be noted, that 0.0.0-dev is already considered floating and as such no extra tag is produced. Testing with a version which will produce a second tag will be done later.
This PR wires up floating tag support for all product images. We currently still default to false to make sure everything continues to work as expected (and without changing behaviour).